cerc-io
/
stack-orchestrator
mirror of https://github.com/cerc-io/stack-orchestrator
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fix: create imagePullSecret in deployment namespace, not default 

create_registry_secret() hardcoded namespace="default" but deployments
now run in dedicated laconic-* namespaces. The secret was invisible
to pods in the deployment namespace, causing 401 on GHCR pulls.

Accept namespace as parameter, passed from deploy_k8s.py which knows
the correct namespace.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
afd-dumpster-local-testing
A. F. Dudley 2026-03-18 19:08:52 +00:00
parent 0b3e5559d0
commit ba39c991f1
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
stack_orchestrator/deploy/deployment_create.py
View File

@ -577,7 +577,9 @@ def _generate_and_store_secrets(config_vars: dict, deployment_name: str):
return secrets return secrets
def create_registry_secret(spec: Spec, deployment_name: str) -> Optional[str]: def create_registry_secret(
spec: Spec, deployment_name: str, namespace: str = "default"
) -> Optional[str]:
"""Create K8s docker-registry secret from spec + environment. """Create K8s docker-registry secret from spec + environment.
Reads registry configuration from spec.yml and creates a Kubernetes Reads registry configuration from spec.yml and creates a Kubernetes
@ -586,6 +588,7 @@ def create_registry_secret(spec: Spec, deployment_name: str) -> Optional[str]:
Args: Args:
spec: The deployment spec containing image-registry config spec: The deployment spec containing image-registry config
deployment_name: Name of the deployment (used for secret naming) deployment_name: Name of the deployment (used for secret naming)
namespace: K8s namespace to create the secret in
Returns: Returns:
The secret name if created, None if no registry config The secret name if created, None if no registry config
@ -633,7 +636,6 @@ def create_registry_secret(spec: Spec, deployment_name: str) -> Optional[str]:
return None return None
v1 = client.CoreV1Api() v1 = client.CoreV1Api()
namespace = "default"
k8s_secret = client.V1Secret( k8s_secret = client.V1Secret(
metadata=client.V1ObjectMeta(name=secret_name), metadata=client.V1ObjectMeta(name=secret_name),

4
stack_orchestrator/deploy/k8s/deploy_k8s.py
View File

@ -541,7 +541,9 @@ class K8sDeployer(Deployer):
# Create registry secret if configured # Create registry secret if configured
from stack_orchestrator.deploy.deployment_create import create_registry_secret from stack_orchestrator.deploy.deployment_create import create_registry_secret
create_registry_secret(self.cluster_info.spec, self.cluster_info.app_name) create_registry_secret(
self.cluster_info.spec, self.cluster_info.app_name, self.k8s_namespace
)
self._create_volume_data() self._create_volume_data()
self._create_deployment() self._create_deployment()