refactor: rename `deployment update` to `deployment update-envs`
The update command only patches environment variables and adds a restart annotation. It does not update ports, volumes, configmaps, or any other deployment spec. The old name was misleading — it implied a full spec update, causing operators to expect changes that never took effect. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>fix/kind-mount-propagation
parent
7f205732f2
commit
806c1bb723
|
|
@ -62,7 +62,7 @@ class DockerDeployer(Deployer):
|
||||||
except DockerException as e:
|
except DockerException as e:
|
||||||
raise DeployerException(e)
|
raise DeployerException(e)
|
||||||
|
|
||||||
def update(self):
|
def update_envs(self):
|
||||||
if not opts.o.dry_run:
|
if not opts.o.dry_run:
|
||||||
try:
|
try:
|
||||||
return self.docker.compose.restart()
|
return self.docker.compose.restart()
|
||||||
|
|
|
||||||
|
|
@ -182,8 +182,8 @@ def status_operation(ctx):
|
||||||
ctx.obj.deployer.status()
|
ctx.obj.deployer.status()
|
||||||
|
|
||||||
|
|
||||||
def update_operation(ctx):
|
def update_envs_operation(ctx):
|
||||||
ctx.obj.deployer.update()
|
ctx.obj.deployer.update_envs()
|
||||||
|
|
||||||
|
|
||||||
def ps_operation(ctx):
|
def ps_operation(ctx):
|
||||||
|
|
|
||||||
|
|
@ -28,7 +28,7 @@ class Deployer(ABC):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
@abstractmethod
|
@abstractmethod
|
||||||
def update(self):
|
def update_envs(self):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
@abstractmethod
|
@abstractmethod
|
||||||
|
|
|
||||||
|
|
@ -31,7 +31,7 @@ from stack_orchestrator.deploy.deploy import (
|
||||||
exec_operation,
|
exec_operation,
|
||||||
logs_operation,
|
logs_operation,
|
||||||
create_deploy_context,
|
create_deploy_context,
|
||||||
update_operation,
|
update_envs_operation,
|
||||||
)
|
)
|
||||||
from stack_orchestrator.deploy.deploy_types import DeployCommandContext
|
from stack_orchestrator.deploy.deploy_types import DeployCommandContext
|
||||||
from stack_orchestrator.deploy.deployment_context import DeploymentContext
|
from stack_orchestrator.deploy.deployment_context import DeploymentContext
|
||||||
|
|
@ -210,11 +210,11 @@ def status(ctx):
|
||||||
status_operation(ctx)
|
status_operation(ctx)
|
||||||
|
|
||||||
|
|
||||||
@command.command()
|
@command.command(name="update-envs")
|
||||||
@click.pass_context
|
@click.pass_context
|
||||||
def update(ctx):
|
def update_envs(ctx):
|
||||||
ctx.obj = make_deploy_context(ctx)
|
ctx.obj = make_deploy_context(ctx)
|
||||||
update_operation(ctx)
|
update_envs_operation(ctx)
|
||||||
|
|
||||||
|
|
||||||
@command.command()
|
@command.command()
|
||||||
|
|
|
||||||
|
|
@ -598,7 +598,7 @@ class K8sDeployer(Deployer):
|
||||||
log_data = "******* No logs available ********\n"
|
log_data = "******* No logs available ********\n"
|
||||||
return log_stream_from_string(log_data)
|
return log_stream_from_string(log_data)
|
||||||
|
|
||||||
def update(self):
|
def update_envs(self):
|
||||||
self.connect_api()
|
self.connect_api()
|
||||||
ref_deployment = self.cluster_info.get_deployment()
|
ref_deployment = self.cluster_info.get_deployment()
|
||||||
if not ref_deployment or not ref_deployment.metadata:
|
if not ref_deployment or not ref_deployment.metadata:
|
||||||
|
|
|
||||||
|
|
@ -696,7 +696,7 @@ def deploy_to_k8s(deploy_record, deployment_dir, recreate, logger):
|
||||||
if not deploy_record:
|
if not deploy_record:
|
||||||
commands_to_run = ["start"]
|
commands_to_run = ["start"]
|
||||||
else:
|
else:
|
||||||
commands_to_run = ["update"]
|
commands_to_run = ["update-envs"]
|
||||||
|
|
||||||
for command in commands_to_run:
|
for command in commands_to_run:
|
||||||
logger.log(f"Running {command} command on deployment dir: {deployment_dir}")
|
logger.log(f"Running {command} command on deployment dir: {deployment_dir}")
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue