From 787806d6fa28b565b0130802bed8d7b885646605 Mon Sep 17 00:00:00 2001 From: Prathamesh Musale Date: Thu, 2 Apr 2026 08:11:03 +0000 Subject: [PATCH] fix: wait_for_log_output should ignore "No logs available" responses The k8s logs command returns "No logs available" or "Pods not running" when containers aren't ready yet. Since these are non-empty strings, wait_for_log_output() was treating them as success, causing the subsequent content check to fail. Also fix unquoted echo glob expansion. Co-Authored-By: Claude Opus 4.6 --- tests/container-registry/run-test.sh | 4 ++-- tests/k8s-deployment-control/run-test.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/container-registry/run-test.sh b/tests/container-registry/run-test.sh index fb0c8e1a..a1abd15b 100755 --- a/tests/container-registry/run-test.sh +++ b/tests/container-registry/run-test.sh @@ -34,7 +34,7 @@ wait_for_log_output () { local log_output=$( $TEST_TARGET_SO deployment --dir $test_deployment_dir logs ) - if [[ ! -z "$log_output" ]]; then + if [[ ! -z "$log_output" ]] && [[ "$log_output" != *"No logs available"* ]] && [[ "$log_output" != *"Pods not running"* ]]; then # if ready, return return else @@ -121,7 +121,7 @@ if [[ "$log_output_3" == *"listening on"* ]]; then echo "deployment logs test: passed" else echo "deployment logs test: FAILED" - echo $log_output_3 + echo "$log_output_3" delete_cluster_exit fi diff --git a/tests/k8s-deployment-control/run-test.sh b/tests/k8s-deployment-control/run-test.sh index e964aa6c..89a7d06d 100755 --- a/tests/k8s-deployment-control/run-test.sh +++ b/tests/k8s-deployment-control/run-test.sh @@ -38,7 +38,7 @@ wait_for_log_output () { local log_output=$( $TEST_TARGET_SO deployment --dir $test_deployment_dir logs ) - if [[ ! -z "$log_output" ]]; then + if [[ ! -z "$log_output" ]] && [[ "$log_output" != *"No logs available"* ]] && [[ "$log_output" != *"Pods not running"* ]]; then # if ready, return return else